Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why not retrain on full dataset if eval_method = cv? #131

Closed
stepthom opened this issue Jul 8, 2021 · 2 comments
Closed

Question: Why not retrain on full dataset if eval_method = cv? #131

stepthom opened this issue Jul 8, 2021 · 2 comments

Comments

@stepthom
Copy link
Collaborator

stepthom commented Jul 8, 2021

I noticed that FLAML will only retrain on the full dataset if the eval_method parameter is set to 'holdout':

FLAML/flaml/automl.py

Lines 910 to 911 in b04b00d

self._retrain_full = retrain_full and (
eval_method == 'holdout' and self._state.X_val is None)

Why not retrain on full dataset for other eval_methods, such as 'cv'?

@sonichi
Copy link
Collaborator

sonichi commented Jul 8, 2021

The retraining happens right after cross-validation:

estimator.fit(X_train_all, y_train_all, budget, **fit_kwargs)

@stepthom
Copy link
Collaborator Author

stepthom commented Jul 8, 2021

Oh, I see - thank you very much! 👍

@stepthom stepthom closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants