Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

[RFC] Alternatives to Awkward Variant Modifiers #2

Closed
dvdzkwsk opened this issue Jul 20, 2018 · 1 comment
Closed

[RFC] Alternatives to Awkward Variant Modifiers #2

dvdzkwsk opened this issue Jul 20, 2018 · 1 comment
Labels
RFC vsts Paired with ticket in vsts

Comments

@dvdzkwsk
Copy link
Contributor

Linked from stardust-ui/react-old#2.

Feature Request

Problem description

In Semantic UI V1 we supported modifiers/variants such as:

<Button basic />        // this is cool
<Button basic="very" /> // this is not

The problem with this is that it's extremely unintuitive, reads awkwardly, and overloads what should be a boolean or otherwise mutually exclusive property (basic).

Proposed solution

This issue is designed to encourage conversation around alternatives to this problem. One simple idea would be to support something like:

<Button basic />
<Button veryBasic />

Better ideas are encouraged.

@levithomason
Copy link
Member

We are dealing with this on a case by case basis. The agreement is to not have any property-value pairs that make for awkward english reading.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
RFC vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

4 participants