Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix all attrs with a unique label #42

Open
daniel-robertson opened this issue Feb 3, 2021 · 2 comments
Open

Prefix all attrs with a unique label #42

daniel-robertson opened this issue Feb 3, 2021 · 2 comments

Comments

@daniel-robertson
Copy link
Member

daniel-robertson commented Feb 3, 2021

Describe the feature that you would like added

In order to prevent naming conflicts with other libraries and apps, it is best to prefix attrs with something unique. I think fluentui makes the most sense given that the attrs in attrs.xml are already prefixed with it.

What component or utility would this be added to

Files such as attrs_avatar.xml, attrs_people_picker.xml, attrs_avatar_group.xml, etc. all need to have unique attrs to avoid conflicts.

Have you discussed this feature with our team, and if so, who

No

Additional context/screenshots

Compiling the library into our app results in compilation errors such as:
AAPT: error: duplicate value for resource 'attr/type' with config ''.
AAPT: error: duplicate value for resource 'attr/avatarSize' with config ''.

@ejlayne
Copy link

ejlayne commented May 6, 2021

@aishwarya56 Daniel reached out to me about this, we should make sure this is addressed for vNext components. Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants