Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListVnext] Refactor cell layout (height) definition #367

Closed
1 of 2 tasks
sophialee0416 opened this issue Dec 31, 2020 · 1 comment · Fixed by #401
Closed
1 of 2 tasks

[ListVnext] Refactor cell layout (height) definition #367

sophialee0416 opened this issue Dec 31, 2020 · 1 comment · Fixed by #401
Assignees
Labels
vnext-prototype Changes meant to be merged to the vnext-prototype branch.

Comments

@sophialee0416
Copy link
Contributor

sophialee0416 commented Dec 31, 2020

Platform

  • iOS
  • macOS

Describe the feature that you would like added

Cell layout (height) definition currently is determined in a List's section. This ensures that any cell within a section will always have uniform height. However, we can also consider moving this as a responsibility for each individual List cell, which will require the client to set the cell height multiple times instead of once. On the other hand, it can allow a List section to have cells of varying height.

We should discuss if having a section of cells with varying height is something should be done, or if we should restrict cells within a section to maintain same height for consistency.

What component or utility would this be added to

ListVnext, ListCellVnext

@sophialee0416 sophialee0416 self-assigned this Dec 31, 2020
@sophialee0416 sophialee0416 added the vnext-prototype Changes meant to be merged to the vnext-prototype branch. label Jan 1, 2021
@harrieshin harrieshin added this to To do in vnext controls Jan 4, 2021
@sophialee0416
Copy link
Contributor Author

Part of this will be resolved by Issue #364

@sophialee0416 sophialee0416 linked a pull request Jan 19, 2021 that will close this issue
7 tasks
@sophialee0416 sophialee0416 linked a pull request Jan 19, 2021 that will close this issue
7 tasks
@sophialee0416 sophialee0416 moved this from To do to Done in vnext controls Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vnext-prototype Changes meant to be merged to the vnext-prototype branch.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant