Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overrideTokens replace theme-wide tokens, instead of cascading #985

Closed
1 of 2 tasks
mischreiber opened this issue May 17, 2022 · 3 comments
Closed
1 of 2 tasks

overrideTokens replace theme-wide tokens, instead of cascading #985

mischreiber opened this issue May 17, 2022 · 3 comments
Assignees
Labels
fluent2-tokens Changes meant to be merged to the fluent2-tokens branch.

Comments

@mischreiber
Copy link
Contributor

Environment Information

  • Platform:
    • iOS
    • macOS
  • Package version(s): 0.5.0, all package managers
  • Xcode and OS versions: Xcode 13.3.1, iOS 15.x

Please provide a reproduction of the bug:

  • Open a demo view that supports both per-control override and theme-wide override tokens (e.g. CardNudge)
  • Update theme-wide override to include additional properties beyond what are covered by per-control override tokens (e.g. accentColor)
  • Enable theme-wide override, then per-control override.

Actual behavior:

Theme-wide custom accentColor is replaced by default value.

Expected behavior:

Theme-wide custom accentColor is maintained, as per-control override doesn't override that value.

Priorities and help requested:

Are you willing to submit a PR to fix? (Yes, No)

Requested priority: (Blocking, High, Normal, Low)

Products/applications affected: (if applicable)

@mischreiber mischreiber added the fluent2-tokens Changes meant to be merged to the fluent2-tokens branch. label May 17, 2022
@mischreiber mischreiber self-assigned this May 17, 2022
@mischreiber
Copy link
Contributor Author

The fix for this will be to implement some form of cascading token resolution. I have a WIP in my personal fork; PR expected in the coming days.

@mischreiber
Copy link
Contributor Author

This is now fixed in the fluent2-tokens branch. Next step will be merging to main.

@mischreiber
Copy link
Contributor Author

Resolved back with #1219, which is now released in the 0.8 branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fluent2-tokens Changes meant to be merged to the fluent2-tokens branch.
Projects
None yet
Development

No branches or pull requests

1 participant