Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to input other decimal separators in FluentNumberField #1942

Closed
MarvinKlein1508 opened this issue Apr 25, 2024 · 3 comments
Closed

Allow to input other decimal separators in FluentNumberField #1942

MarvinKlein1508 opened this issue Apr 25, 2024 · 3 comments
Labels
triage New issue. Needs to be looked at

Comments

@MarvinKlein1508
Copy link
Contributor

馃檵 Feature Request

In some countries decimals are separated with a different symbol besides . for example in Germany we use ,. The FluentNumberField only allows to enter decimals with . though and not with other symbols for other CultureInfos. This makes it much harder for users to use the component when they type numbers with the numpad for example.

馃 Expected Behavior

This component should support other decimal separators as well and converts them into CultureInfo.InvarientCulture

@microsoft-github-policy-service microsoft-github-policy-service bot added the triage New issue. Needs to be looked at label Apr 25, 2024
@vnbaaij vnbaaij removed the triage New issue. Needs to be looked at label Apr 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the triage New issue. Needs to be looked at label Apr 25, 2024
@vnbaaij
Copy link
Collaborator

vnbaaij commented Apr 25, 2024

This is not supported by the underlying input type.

The FluentNumberField is not a good component. I would advise you not to use it.

In a lot of cases it is not even a nice way of inputting a value. My advise is to use a FluentTextField with the InputMode="InputMode.Numeric" settin. Gives you a nice number keyboard on a mobile device (and adapts to regional settings):
image

@vnbaaij vnbaaij closed this as completed Apr 25, 2024
@MarvinKlein1508
Copy link
Contributor Author

@vnbaaij but how would you bind to anything else besides a string then?

@vnbaaij
Copy link
Collaborator

vnbaaij commented May 2, 2024

You'll have to do the conversion yourself then. Not ideal, I know but FluentNumberField or actually fluent-number-filed is really broken at the core and I'm not expecting fixes unitl v3 of the web components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage New issue. Needs to be looked at
Projects
None yet
Development

No branches or pull requests

2 participants