Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Accessibility issues in FluentNavMenu #847

Closed
tlmii opened this issue Oct 12, 2023 · 1 comment 路 Fixed by #853
Closed

fix: Accessibility issues in FluentNavMenu #847

tlmii opened this issue Oct 12, 2023 · 1 comment 路 Fixed by #853
Assignees
@dvoituron

Comments

@tlmii
Copy link
Member

tlmii commented Oct 12, 2023

馃悰 Bug Report

Accessibility Insights shows several issues with the FluentNavMenu.

  1. The div.fluent-nav-menu should probably have a role="menu" attribute
  2. The div.fluent-nav-item elements should have a role="menuitem" attribute
  3. The div.expand-collapse-button elements should have tabindex="-1" instead of 0 because it is set to aria-hidden="true", or aria-hidden="true" should be removed

There might be something that needs to be done with fluent-nav-group too, since it has fluent-nav-item children, but I'm not sure the right role for it (that error doesn't come up until you start fixing some of the others)

馃捇 Repro or Code Sample

These can be seen on https://www.fluentui-blazor.net/:
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvoituron dvoituron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Accessibility] Fix some FluentButton and FluentNav aria attributes microsoft/fluentui-blazor
2 participants
@dvoituron @tlmii