Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Accessibility Issue in FluentDialogHeader #848

Closed
tlmii opened this issue Oct 12, 2023 · 2 comments · Fixed by #853
Closed

fix: Accessibility Issue in FluentDialogHeader #848

tlmii opened this issue Oct 12, 2023 · 2 comments · Fixed by #853
Assignees
@dvoituron

Comments

@tlmii
Copy link
Member

tlmii commented Oct 12, 2023

🐛 Bug Report

The dismiss button in the header of the dialog doesn't have a title/aria-label

💻 Repro or Code Sample

This can be seen on https://www.fluentui-blazor.net/Dialog:
image
@dvoituron
Copy link
Collaborator

You're right. But my problem is more with the FluentButton (used to display the Dismiss icon). I'm fixing it for the next version.

@dvoituron dvoituron self-assigned this Oct 13, 2023
@dvoituron dvoituron mentioned this issue Oct 13, 2023
Merged
@dvoituron
Copy link
Collaborator

Fixed in PR #853

@tlmii tlmii mentioned this issue Oct 17, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvoituron dvoituron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Accessibility] Fix some FluentButton and FluentNav aria attributes microsoft/fluentui-blazor
2 participants
@dvoituron @tlmii