Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some emoji lacking skin tone data #15

Closed
bignutty opened this issue Aug 10, 2022 · 5 comments · Fixed by #23
Closed

Some emoji lacking skin tone data #15

bignutty opened this issue Aug 10, 2022 · 5 comments · Fixed by #23

Comments

@bignutty
Copy link

First of all i'm incredibly thankful that you decided to open-source these.

I've tried to write a small script that convert the emoji into (codepoints).svg and noticed that certain emoji like 🤼‍♀️ woman wrestling lack unicodeSkintones in their metadata.json despite having skin tone variants

Would it be possible to get this fixed or provide a download that has all files with just their codepoints as names?
@ghost
Copy link

ghost commented Aug 10, 2022 •
edited by ghost

Thanks for opening this issue! @justsomederpystuff

I wanted to ask if there was a way or code you used to detected the lack of unicodeSkintones and if there are other emoji that are missing it that need it.

@ghost ghost assigned ghost and unassigned william-msft Aug 10, 2022
@bignutty
Copy link
Author

bignutty commented Aug 10, 2022 •
edited

all emojis that i noticed were

folded hands (🙏)
man genie (🧞‍♂️)
men with bunny ears (👯‍♂️)
men wrestling (🤼‍♂️)
man zombie (🧟‍♂️)
genie (🧞)
person in bed (🛌)
person in steamy room (🧖)
people wrestling (🤼)
zombie (🧟)
skier (⛷️)
woman genie (🧞‍♀️)
women with bunny ears (👯‍♀️)
women wrestling (🤼‍♀️)
woman zombie (🧟‍♀️)

my code effectively just went through all directories under /assets/ and reported an error if there were any skintone subdirectories present yet no unicodeSkintones in metadata.json

the zombie ones are odd since they follow the skintone format (having a Default folder) while not providing any alternative types (should probably use the same format as all other regular emoji)

In addition, playground slide (🛝) seems to be missing its Color directory. wheel seems to be missing its metadata.json entirely.

@ghost ghost linked a pull request Aug 10, 2022 that will close this issue
Added some unicode skin tones, added person in bed files, and folders… #23
Merged
@ghost
Copy link

ghost commented Aug 10, 2022

@justsomederpystuff created a PR to address the majority of this

The following emoji don't have unicode skin tone values according to Unicode 14.0

  • men with bunny ears (👯‍♂️)
  • men wrestling (🤼‍♂️)
  • people wrestling (🤼)
  • skier (⛷️)
  • women with bunny ears (👯‍♀️)
  • women wrestling (🤼‍♀️)

@ghost ghost closed this as completed in #23 Aug 10, 2022
@Davr1
Copy link

Davr1 commented Aug 15, 2022

I've noticed that some of the emojis justsomederpystuff mentioned are actually present in unrelated metadata files:

handshake: 🤝 🙏 🙏🏻 🙏🏼 🙏🏽 🙏🏾
(person) genie: 🧞 🧞‍♂️ 🧞‍♀️ 🧟 🧟‍♂️ 🧟‍♀️
people/person with bunny ears: 👯 👯‍♂️ 👯‍♀️ 🧖 🧖🏻 🧖🏼

@JeLuF JeLuF mentioned this issue Aug 15, 2022
Closed
@dav3shanahan
Copy link

why can't you change the skin tone color of emojis in Windows 11?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added some unicode skin tones, added person in bed files, and folders… microsoft/fluentui-emoji
4 participants
@bignutty @Davr1 @dav3shanahan @william-msft