Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should use WeakMaps for the theme settings cache instead of Symbol #117

Closed
FalseLobster opened this issue Mar 3, 2020 · 1 comment
Closed

We should use WeakMaps for the theme settings cache instead of Symbol #117

FalseLobster opened this issue Mar 3, 2020 · 1 comment

Comments

@FalseLobster
Copy link
Contributor

Symbols seem copy-able in the babel transpilation down to ES5. Currently I'm deleting the old theme settings cache in resolvePartialTheme

@JasonVMo FYI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FalseLobster