Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid dimensions in a few icons #147

Closed
cyberalien opened this issue Jan 2, 2021 · 1 comment · Fixed by #150
Closed

Invalid dimensions in a few icons #147

cyberalien opened this issue Jan 2, 2021 · 1 comment · Fixed by #150
Assignees
Labels

Comments

@cyberalien
Copy link

Several SVGs have incorrect dimensions:

ic_fluent_more_24_regular.svg: 25 x 24
ic_fluent_more_24_filled.svg: 25 x 24
ic_fluent_more_28_regular.svg: 29 x 28
ic_fluent_more_48_filled.svg: 49 x 48
ic_fluent_more_48_regular.svg: 49 x 48
ic_fluent_scale_fit_16_filled.svg: 17 x 16
ic_fluent_scale_fit_16_regular.svg: 17 x 16
ic_fluent_scale_fit_20_filled.svg: 21 x 20
ic_fluent_scale_fit_24_filled.svg: 25 x 24
ic_fluent_scale_fit_20_regular.svg: 21 x 20
ic_fluent_text_number_format_24_regular.svg: 20 x 20
ic_fluent_weather_hail_day_24_filled.svg: 48 x 48
ic_fluent_weather_hail_night_24_filled.svg: 48 x 48
ic_fluent_weather_thunderstorm_24_filled.svg: 48 x 48

Would it make sense to fix them and make a pull request? Or are SVGs generated, so fixing them in pull request would be pointless?

@spencer-nelson spencer-nelson linked a pull request Jan 4, 2021 that will close this issue
@spencer-nelson spencer-nelson self-assigned this Jan 4, 2021
@spencer-nelson
Copy link
Member

Thanks for bringing these up. They should all be corrected in a new PR this week. Note that More has been renamed to More Horizontal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants