New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fillable SVG #52
Comments
Heyo @Obin Thanks for letting us know. We are in the process of updating our repo to reflect this change (as there didn't seem to be any way to fix it in Figma). We're hoping to test it next week, so hopefully the library will reflect those changes in the short term. Thanks for your patience. |
@jasoncuster Did this ever get pushed up as a change? I think the week passed 😆 (I mean that in jest in case it wasn't obvious by context). |
@ScottAwesome Apologies for the delay. We have a solution tested and ready but where it's a change that hits all of the files at once are hoping to batch it in with another couple of full-library technical fixes which require a designer to run through the effect with a fine tooth comb. Our goal is to complete all these in December. Do you have a more urgent need for the change than that? |
@spencer-nelson I appreciate the response! No I don't have a more urgent need than that at this time, I really look forward to seeing that work though! Is there any timeline for release in December for this? |
With the publishing of the @fluentui/svg-icons package in npm this was resolved by removing all fill data from the processed svgs. We suggest setting that as a dependency for fillable SVGs. |
SVG files should not use internal
fill
rule for coloring things, because then CSS rulefill
cannot be easily applied.For example
App
regular icon oryginal:App
regular icon fillable by CSSfill
:But if you really need to stay with default color, then use
fill
on SVG element directly whith can be overriden by CSSfill
:The text was updated successfully, but these errors were encountered: