Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip of dismiss button in Dialog control is not opened on tabbing through keyboard #13286

Closed
Harkesh030679 opened this issue May 22, 2020 · 4 comments
Assignees
Labels
Component: Dialog Resolution: Soft Close Soft closing inactive issues over a certain period Status: Not on Roadmap Issue is not currently on roadmap, no fix planned Type: Feature

Comments

@Harkesh030679
Copy link

Tooltip of cross button in Dialog control is not opened on tabbing through keyboard

Environment Information

OS: Win10
Browser: Chrome, Edge

Describe the issue:

Tooltip of cross button in Dialog control is not opened on tabbing through keyboard, Tooltip is opened on hover properly

Please provide a reproduction of the issue in a codepen:

Link
https://developer.microsoft.com/en-us/fluentui#/controls/web/dialog
Snap
Dialog

Actual behavior:

Tooltip of cross button in Dialog control is not opened on tabbing through keyboard

Expected behavior:

Tooltip of cross button in Dialog control should be opened on tabbing through keyboard

Documentation describing expected behavior

@aneeshack4
Copy link
Contributor

@Harkesh030679 You can wrap it in TooltipHost like in the examples here https://developer.microsoft.com/en-us/fluentui#/controls/web/tooltip

@ecraig12345 ecraig12345 changed the title Tooltip of cross button in Dialog control is not opened on tabbing through keyboard Tooltip of dismiss button in Dialog control is not opened on tabbing through keyboard May 22, 2020
@aneeshack4
Copy link
Contributor

Oops my bad - there's actually no custom renderer available. @ecraig12345 has more details on this.

@ecraig12345
Copy link
Member

At this point it's expected that the tooltip won't open on keyboard focus of the dismiss button because we're using only the browser's native tooltip (title property), which doesn't work that way. @aneeshack4 is right that we could add a tooltip that opens on keyboard focus by wrapping the button in a TooltipHost, but this isn't something we'd want to add by default due to bundle size concerns.

We could however consider adding a custom renderer onRenderDismissButton which would let you wrap with the button with a TooltipHost yourself. I've marked this as a feature for backlog review (if we do this it should also be added to Panel and other controls with dismiss buttons), though we may not get to it for awhile since we're currently focused on larger work items around performance and coherence. It's also possible we may want to defer this until a later version where we have slots available instead of custom render functions.

@ecraig12345 ecraig12345 added Status: Not on Roadmap Issue is not currently on roadmap, no fix planned and removed Needs: Backlog review labels Jan 23, 2021
@ecraig12345 ecraig12345 removed their assignment Jan 23, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Feb 4, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: Dialog Resolution: Soft Close Soft closing inactive issues over a certain period Status: Not on Roadmap Issue is not currently on roadmap, no fix planned Type: Feature
Projects
None yet
Development

No branches or pull requests

6 participants