Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persona remove button doesn't have tooltip #14902

Closed
ravi-405 opened this issue Sep 4, 2020 · 11 comments
Closed

Persona remove button doesn't have tooltip #14902

ravi-405 opened this issue Sep 4, 2020 · 11 comments

Comments

@ravi-405
Copy link

ravi-405 commented Sep 4, 2020

User Experience:
Users who depends on screen reader are facing difficulty as title is not defined for "People picker" remove button.

Repro Steps:
Step 1: Open https://fabricweb.z5.web.core.windows.net/oufr/7.105.2/#/examples/peoplepicker
Step 2: Search for any user in the people picker and select one user.
Step 3: Navigate to "Remove" button in persona and observe the tooltip.

Actual Result:
Close(X) button tooltip is not defined when focus is on close button.

Expected Result:
Close(X) button should have tooltip.

@paulgildea paulgildea added Component: PeoplePicker Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Component: Persona and removed Needs: Triage 🔍 labels Sep 9, 2020
@paulgildea
Copy link
Member

@ravi-405 Thanks for the feedback!

@joschect - Is there any way to target the (X) button on the People Picker to wrap with a ToolTip?

@miroslavstastny
Copy link
Member

@ravi-405 - can you please specify what screenreader/browser combination have you used and also your key sequence to focus the X button?

FYI @smhigley, @kolaps33 - not sure what the expected remove item workflow is.

@miroslavstastny miroslavstastny added Area: Accessibility Needs: Actionable Feedback 🕵️‍♀️ and removed Needs: Investigation The Shield Dev should investigate this issue and propose a fix labels Sep 16, 2020
@msft-github-bot
Copy link
Contributor

Thanks for taking the time to enter an issue. However, it seems that there aren't enough details here for this issue to be actionable.

When issues are created, we need details such as:

  1. Which Fluent UI component is causing the issue
  2. Which package name and version the component is from
  3. Specific, complete steps to reproduce the issue
  4. What behaviors and attributes are missing or incorrect
  5. What you expected and what is actually happening
  6. Confirmation that the problem reproduces in isolation

Without a clear understanding of these details, it's not possible to take clear action on issues. We are unable to meet your expectations, properly address the root cause, and make changes without affecting the expectations of other consumers.

Please provide these additional details as you are able. The default issue template provides an outline of these details and is viewable when creating a new issue. Additionally, if this is an accessibility issue, please see Accessibility Troubleshooting in our wiki for more guidance. If these details cannot be provided, please kindly close the issue.

Thank you for your patience.

@msft-github-bot
Copy link
Contributor

This issue has been automatically marked as stale because it has marked as requiring actionable feedback but has not had any activity for 2 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fluent UI!

@msft-github-bot
Copy link
Contributor

This issue has been automatically marked as stale because it has marked as requiring actionable feedback but has not had any activity for 2 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fluent UI!

@ravi-405
Copy link
Author

@miroslavstastny , Using NVDA + edge dev combination.

Key Sequence - on mouse hover.

Thanks

@msft-github-bot
Copy link
Contributor

@miroslavstastny

Gentle ping that this issue needs attention.

@v-ajrai
Copy link

v-ajrai commented Nov 11, 2020

@paulgildea .
I am also facing the similar issue. Do we have any update on Estimated time for this to be resolved.
external_11

@smhigley
Copy link
Contributor

I don't think an accessibility tag is appropriate for this issue. Adding a tooltip has dubious accessibility benefits for an icon as well-known as close/clear, and definite accessibility drawbacks. Particularly within a control like a combobox, adding a secondary popup in addition to the main listbox and text input is going to cause complications around e.g. keyboard dismissal.

I wouldn't go so far as to say accessibility concerns mean that a tooltip shouldn't be added, but it's certainly not a WCAG requirement and debateably not a net accessibility benefit.

@joshmccall221
Copy link

You need to specify removeButtonAriaLabel:

    <CompactPeoplePicker
        removeButtonAriaLabel={'Remove'} 

see issue #14776:

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Feb 4, 2022
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft microsoft locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants