Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The CompactPeoplePicker field shrinks in height a bit when a Persona is selected. #14904

Closed
belozerovany opened this issue Sep 4, 2020 · 4 comments
Assignees
Labels
Component: PeoplePicker Fluent UI react (v8) Issues about @fluentui/react (v8) Resolution: Soft Close Soft closing inactive issues over a certain period Type: Bug 🐛

Comments

@belozerovany
Copy link

Environment Information

  • Package version(s): (7.0.1)
  • Browser and OS versions: (all)

Please provide a reproduction of the bug in a codepen:

codepen: https://codepen.io/belozerovany/pen/LYNzRvY?editors=0010

Actual behavior:

The CompactPeoplePicker field shrinks in height a bit when a Persona is selected.

Problem is in {itemLimit=1}. When we set this property div(.ms-BasePicker-text) change own height by a child element. When we do not use itemLimit div`s height depend on the supplementary element "input" wish added for the next select.

Expected behavior:

The CompactPeoplePicker field should not shrinks in height a bit when a Persona is selected.

Priorities and help requested:

Are you willing to submit a PR to fix? No

Requested priority: High

Products/sites affected: Products

@paulgildea paulgildea added Component: PeoplePicker Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix and removed Needs: Triage 🔍 labels Sep 9, 2020
@paulgildea
Copy link
Member

@belozerovany Thanks for the feedback!

@miroslavstastny - Determine if this repo-ing in the latest version. We may have already fixed this.

@miroslavstastny
Copy link
Member

@paulgildea I can repro with the latest office-ui-fabric-react@7.136.0. Will debug more.

@miroslavstastny miroslavstastny added Type: Bug 🐛 and removed Needs: Investigation The Shield Dev should investigate this issue and propose a fix labels Sep 25, 2020
@miroslavstastny
Copy link
Member

Reassigning to @joschect.

The problem occurs not only when itemLimit=1 but whenever the limit is reached. This also affects cases when the input is multiline. The following example is with itemLimit=3:
output

@khmakoto khmakoto assigned tomi-msft and unassigned joschect May 18, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

Because this reported issue has not had any activity for over 180 days, we're automatically closing it for house-keeping reasons.

Still require assistance? Please, create a new issue with up-to date details and latest version of Fluent.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Feb 4, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: PeoplePicker Fluent UI react (v8) Issues about @fluentui/react (v8) Resolution: Soft Close Soft closing inactive issues over a certain period Type: Bug 🐛
Projects
None yet
Development

No branches or pull requests

7 participants