Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips do not dismiss on ctrl #14987

Closed
HaTheo opened this issue Sep 10, 2020 · 2 comments · Fixed by #15000
Closed

Tooltips do not dismiss on ctrl #14987

HaTheo opened this issue Sep 10, 2020 · 2 comments · Fixed by #15000
Assignees
Labels
Area: Accessibility Component: Tooltip Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Status: Fixed Fixed in some PR

Comments

@HaTheo
Copy link

HaTheo commented Sep 10, 2020

We should dismiss via ctrl key as escape closes many dialogs, this is the current behavior in Office.com and was discussed with SME in Control Club and would be great to incorporate into Fluent. Since the esc key propagates while the tool tip is dismissed controls using esc still see normal esc behaviors, on key down of ctrl is a more robust solution.

text bellow is largely copied and is a modified version from this issue:
https://codepen.io/dbjorge/pen/QXbvzN

Actual behavior:
Go to the codepen
Click the "Hover Over Me" element
Press "Tab" then "Shift+Tab" to simulate keyboard navigating to element
Wait for tooltip to appear
Press left or right "ctrl"
Observe that tooltip does not disappear
Expected behavior:
tooltip should be dismissable using ctrl key

Documentation describing expected behavior
From https://www.w3.org/TR/WCAG21/#content-on-hover-or-focus

Violation of Success Criterion 1.4.13 Content on Hover or Focus

@paulgildea
Copy link
Member

@Rainhale Thanks for the feedback.

@smhigley It would be helpful for you to weigh in on this desired behavior.

I'm not opposed to adding if that's the current requirement.

@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #15000, which has now been successfully released as office-ui-fabric-react@v7.139.1.:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Accessibility Component: Tooltip Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Status: Fixed Fixed in some PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants