Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tooltip to Close Button on Panel Sample. #14999

Closed
sophiaFengMS opened this issue Sep 11, 2020 · 2 comments
Closed

Add Tooltip to Close Button on Panel Sample. #14999

sophiaFengMS opened this issue Sep 11, 2020 · 2 comments
Assignees
Labels
Area: Accessibility Area: Documentation Component: Panel Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Resolution: Soft Close Soft closing inactive issues over a certain period

Comments

@sophiaFengMS
Copy link

Environment Information

  • Package version(s): (fill this out)
  • Browser and OS versions: (fill this out)

Describe the issue:

Open the Panel, hover on the close button, the tooltip 'Close' shows. Then try to access the tooltip, it disappears.

Please provide a reproduction of the issue in a codepen:

Can be repro at the website: https://developer.microsoft.com/en-us/fluentui#/controls/web/panel
Open any panel in the Usage

Actual behavior:

The tooltip that appeared on the close button is non-hoverable.

Expected behavior:

The tooltip should be hoverable with the mouse, so that the user can stop them by hovering to them.

Documentation describing expected behavior

As per MAS1.4.13, tooltip itself should be hoverable using mouse. Please find the below Example 2 : Hoverable tooltip
image

@paulgildea
Copy link
Member

@sophiaFengMS Thanks for the feedback.

I am able to hover over the Tooltip component provided on the documentation site: https://developer.microsoft.com/en-us/fluentui#/controls/web/tooltip
image
(sorry I wasn't able to capture the mouse cursor with my snipping tool)

Looking at the Panel sample it doesn't look like it's using the Tooltip component and is using the native browser tooltip.
image

I'll use this issue to track making an update to the sample for Panel as I believe it is necessary for a developer to use the Button component and the Tooltip component together to achieve the desired experience.

@paulgildea paulgildea added Area: Accessibility Component: Panel Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Area: Documentation and removed Needs: Triage 🔍 labels Sep 11, 2020
@paulgildea paulgildea changed the title Tooltip of the close button is not hoverable with mouse. Add Tooltip to Close Button on Panel Sample. Sep 11, 2020
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Apr 26, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Accessibility Area: Documentation Component: Panel Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Resolution: Soft Close Soft closing inactive issues over a certain period
Projects
None yet
Development

No branches or pull requests

5 participants