Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type downleveling (typesVersions) #18441

Open
ecraig12345 opened this issue Jun 3, 2021 · 12 comments
Open

Add type downleveling (typesVersions) #18441

ecraig12345 opened this issue Jun 3, 2021 · 12 comments
Assignees
@Hotell
Labels
Area: Build System Area: Typescript Resolution: Soft Close Soft closing inactive issues over a certain period Type: Epic
Projects
V-Build - @microsoft/fluentui-react-b... !!! OLD DO NOT USE!!! v9.0.0

Comments

@ecraig12345
Copy link
Member

A "good enough" initial solution to ensuring TS 3.9 compatibility is just banning type constructs introduced in 4.0+ (see #18440), but we may want to add actual downleveling in the future. downlevel-dts could help. A bit more discussion on #16101.
@ecraig12345 ecraig12345 created this issue from a note in V-Build - @microsoft/fluentui-react-build (Backlog) Jun 3, 2021
@ecraig12345 ecraig12345 mentioned this issue Jun 3, 2021
Closed
5 tasks
@layershifter
Copy link
Member

@ecraig12345 is it possible you prioritize this? We have already met this problem, for example, in #19281.

@layershifter layershifter mentioned this issue Aug 6, 2021
Merged
@ecraig12345
Copy link
Member Author

@layershifter I'm not sure if I'll have time to work on this along with other things I'm already supposed to be doing. I also wasn't aware that we had a TS minbar < 4 for converged.

@ecraig12345 ecraig12345 added this to Needs Triage in react-components beta via automation Aug 6, 2021
@ecraig12345
Copy link
Member Author

It looks like downlevel-dts is still at the level of a side project at best, though it does support named tuples. A downside is that unless we switched to only shipping a single rollup file, adding a downleveled version of every .d.ts would bloat the package.

The easiest approach might be to add a basic test with TS 3.9 as described in #18440.

@behowell
Copy link
Contributor

@ecraig12345 to follow up on what partner requirements are

@behowell behowell moved this from Needs Triage to Backlog in react-components beta Aug 12, 2021
@miroslavstastny miroslavstastny removed this from Backlog in react-components beta Oct 27, 2021
@miroslavstastny miroslavstastny added this to Needs Triage in !!! OLD DO NOT USE!!! v9.0.0 via automation Oct 27, 2021
@miroslavstastny miroslavstastny moved this from Needs Triage to To do in !!! OLD DO NOT USE!!! v9.0.0 Nov 5, 2021
@Hotell Hotell assigned Hotell and unassigned ecraig12345 Mar 16, 2022
@Hotell Hotell moved this from Backlog to Triage in V-Build - @microsoft/fluentui-react-build Mar 16, 2022
@Hotell
Copy link
Contributor

Hotell commented Mar 16, 2022

based on recent convo regarding BC for popover, I'll explore this during FHL

@Hotell
Copy link
Contributor

Hotell commented Mar 29, 2022 •
edited

I have workable tooling that includes tests automation. Will need to polish that. After that I'll start implementing it for v9

Hotell/blogposts#73 (comment)

@Hotell
Copy link
Contributor

Hotell commented Apr 4, 2022

related: #19537

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Oct 1, 2022
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@layershifter layershifter reopened this Oct 2, 2022
@Hotell
Copy link
Contributor

Hotell commented Nov 2, 2022

this is planned for Q3 22/23

@Hotell Hotell removed Priority 3: Low Resolution: Soft Close Soft closing inactive issues over a certain period labels Nov 2, 2022
@Hotell Hotell mentioned this issue Nov 2, 2022
Open
28 tasks
@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label May 1, 2023
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@layershifter layershifter reopened this May 2, 2023
@microsoft-github-policy-service
Copy link

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service
Copy link

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@Hotell Hotell reopened this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hotell Hotell

Labels
Area: Build System Area: Typescript Resolution: Soft Close Soft closing inactive issues over a certain period Type: Epic
Projects
No open projects
!!! OLD DO NOT USE!!! v9.0.0
To do
V-Build - @microsoft/fluentui-react-b...
  
Triage
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Hotell @ecraig12345 @layershifter @behowell @msft-fluent-ui-bot