Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: add imports auto/alphabetical ordering #18594

Open
Hotell opened this issue Jun 17, 2021 · 17 comments
Open

lint: add imports auto/alphabetical ordering #18594

Hotell opened this issue Jun 17, 2021 · 17 comments
Assignees
Labels
Area: Build System Resolution: Soft Close Soft closing inactive issues over a certain period

Comments

@Hotell
Copy link
Contributor

Hotell commented Jun 17, 2021

Describe the issue:

Actual behavior:

  • we have no imports auto ordering in place
  • comments like this occur on PR's which should be mitigated by tooling:

Expected behavior:

  • lint rules in place with autofixers for whole codebase
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

V-Build - @microsoft/fluentui-react-build automation moved this from Backlog to Done Feb 4, 2022
CXE Prague - @microsoft/cxe-prg automation moved this from Backlog to Done Feb 4, 2022
@Hotell Hotell reopened this Mar 2, 2022
V-Build - @microsoft/fluentui-react-build automation moved this from Done to Backlog Mar 2, 2022
CXE Prague - @microsoft/cxe-prg automation moved this from Done to In progress Mar 2, 2022
@Hotell Hotell removed this from In progress in CXE Prague - @microsoft/cxe-prg Mar 2, 2022
@Hotell Hotell removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Mar 2, 2022
@Hotell Hotell moved this from Backlog to In progress in V-Build - @microsoft/fluentui-react-build Mar 11, 2022
@Hotell Hotell assigned Hotell and unassigned miroslavstastny Mar 11, 2022
@Hotell Hotell moved this from In progress to Triage in V-Build - @microsoft/fluentui-react-build Mar 16, 2022
@layershifter
Copy link
Member

FYI: there is https://github.com/trivago/prettier-plugin-sort-imports

@Hotell
Copy link
Contributor Author

Hotell commented Aug 10, 2022

FYI: there is https://github.com/trivago/prettier-plugin-sort-imports

interesting, this is already implemented and can be used by on demand eslint config https://github.com/microsoft/fluentui/blob/master/packages/eslint-plugin/src/configs/imports.js

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Feb 6, 2023
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@layershifter layershifter reopened this Feb 6, 2023
@layershifter layershifter removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Feb 6, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Aug 25, 2023
@microsoft-github-policy-service

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

2 similar comments
@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

7 similar comments
@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@layershifter layershifter reopened this Aug 28, 2023
@layershifter layershifter removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Aug 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Feb 26, 2024

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build System Resolution: Soft Close Soft closing inactive issues over a certain period
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants