Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect dropdown FastPass errors: elements with an Aria role that require children contain them, elements with an Aria role that require parent roles are contained by them #20280

Closed
caratyler opened this issue Oct 20, 2021 · 3 comments
Labels
Area: Accessibility Component: Dropdown Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix

Comments

@caratyler
Copy link

caratyler commented Oct 20, 2021

  • Package version(s): 8.37.0 and 7.177.2
  • Browser and OS versions: (fill this out if relevant)
  • Note - I see several other dropdown accessibility issues but not this exact one -- e.g, 19518

Describe the issue:

  1. Activate the example for
    v7: Multi-select uncontrolled example here:
    https://fabricweb.z5.web.core.windows.net/oufr/7.177.2/#/examples/dropdown
    v8: Multi-select uncontrolled example here:
    https://fabricweb.z5.web.core.windows.net/oufr/8.37.0/#/examples/dropdown
  2. Run Fast Pass

Actual behavior:

Accessibility insights is failing with the following errors:

  • Certain ARIA roles must contain particular children
  • Certain ARIA roles must be contained by particular parents>

Expected behavior:

Fast pass passes

If applicable, please provide a codepen repro:

v7: Multi-select uncontrolled/controlled example here:
https://fabricweb.z5.web.core.windows.net/oufr/7.177.2/#/examples/dropdown
v8: Multi-select uncontrolled/controlled example here:
https://fabricweb.z5.web.core.windows.net/oufr/8.37.0/#/examples/dropdown

Priorities and help requested (not applicable if asking question):

We are on v7 of Fluent so we are hoping to see a fix there, not just in v8

Are you willing to submit a PR to fix? (Yes, No)
Yes, or help cherry pick the fix back to v7 if necessary

Requested priority: (Blocking, High, Normal, Low)
High - Blocking grade C which is required for release in our organization

Products/sites affected: (if applicable)

@gouttierre gouttierre added Area: Accessibility Component: Dropdown Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix and removed Needs: Triage 🔍 labels Nov 9, 2021
@gouttierre gouttierre added this to Needs triage in Shield Triage Priors (LEGACY - ARCHIVE) via automation Nov 9, 2021
@gouttierre
Copy link
Contributor

@caratyler - Thanks for filing this issue with us. To set expectations the developers will review this issue once capacity allows.

@khmakoto - Would you be able to confirm if this is a regression, or if this behavior is an issue?
cc @smhigley - I am looping you in as you are working with Dropdown convergence.

@smhigley
Copy link
Contributor

This is an error with the automated testing ruleset, and fixed in axe-core v4.3.4: https://github.com/dequelabs/axe-core/releases/tag/v4.3.4

Accessibility Insights is still on 4.3.2.

@smhigley
Copy link
Contributor

(the issue was with recognizing group as a valid child of listbox)

Shield Triage Priors (LEGACY - ARCHIVE) automation moved this from Needs triage to Done Dec 20, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Accessibility Component: Dropdown Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix
Projects
No open projects
Development

No branches or pull requests

5 participants