New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usePopper: define boundaries with imperative handles #21322
Comments
The issue was updated to propose extending existing imperative handle. With the previous proposal (functions) we cannot handle updates of refs properly. |
This has been northstar request, currently not blocking anybody. |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Describe the feature that you would like added
We need to allow define
flipBoundary
andoverflowBoundary
with imperative handles, similarly tosetTarget
.Why?
Currently
flipBoundary
&overflowBoundary
can be defined as elements only ➡️ this requires to use refs viaReact.useState()
:This causes an additional re-render as such boundaries usually wrap a lot of components this results in performance issues. Using imperative handlers allows to avoid passing refs ➡️ additional re-renders.
What component or utility would this be added to
usePopper
hook in@fluentui/react-positioning
The text was updated successfully, but these errors were encountered: