-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-toolbar: manual accessibility checklist #26048
Comments
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
9 similar comments
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
During verification was raised bugs for other components:
[Bug]: HC mode > Focus indicator is not visible for pressed toggle button #26062
[Bug]: HC mode >Primary button state is not reflected in HC mode #26063
[Bug]: HC mode >Tooltip > focus outline inconsistency > Button with tooltip has focus indicator hardly visible #26079
[Bug]: HC mode > focus outline inconsistency > Primary button focus indicator is hardly visible #26077
Related to Tabster:
[Bug]: Toolbar - Radio - JAWS doesn't change to forms mode when user TAB into toolbar #26422
Screen readers bugs:
JAWS narrates wrong instruction message for radiogroup in toolbar #556
Bug 43009970: Narrator - "tool bar" keyword is not narrated for toolbar component
Issue 1408684: VoiceOver keys navigation is broken with toolbar on the page
Issue 1408687: VoiceOver keys navigation is broken with button and heading on the page
>>> as well it can be related to Toolbar on the page, see comment in the bug
Issue 1408735: VoiceOver keys navigation - user is not able navigate outside of toolbar
High-level items:
Testing Notes
For each component tested, write out any specific notes per-step here. Use this section to communicate any non-standard approaches, ambiguous test results, or fully skipped sections.
Color contrast
Steps
Checks
References
High Contrast Mode
Steps
Checks
References
Zoom and Reflow
Steps
Checks
References
Pointer access
Steps
Checks
If a touchscreen isn't available, use common sense/maybe devtools? to mimic a lack of hover.
Note -- this is not only about touch access. A number of assistive tech devices function like a pointer, but lack hover (e.g. eye control or switch control).
Keyboard access
Steps
Checks
<span tabindex="0">some text</span>
should not have a tabindex and should not get focus, even if it has a tooltip or a click event (that would be a separate issue).References
Code conformance
Steps
Checks
To check for valid semantics, look at the following:
role=""
attribute, or implicit based on the HTML element)To check for visually-hidden text:
aria-label
s set within the component code, and any freeform string props that do not visually show upFor any strings that are required to be present for the accessibility reasons (e.g. icon button labels), the string must come from our own props, following our internationalization pattern. It should not be up to authors to know they need to manually set an> Not applicable for toolbararia-label
or other native attribute.References
Screen reader access
Screen reader combinations:
Steps
For Windows screen readers:
For VoiceOver on macOS:
Touch screen readers:
Checks
For all screen readers, within all screen-reader-specific tests, check the following:
All visual text and non-presentational graphics and icons are available with the screen reader> Not applicable for toolbarChanges that should be announced asynchronously are announced through a live region. Changes that do not need a live region do not use one.> Not applicable for toolbarSpecific per-screen-reader checks:
All relevant component-type shortcuts (e.g. "c" for comboboxes) bring the cursor to the correct element> Not applicable for toolbarCheck that using the rotor brings the VO cursor to the correct place> Not applicable for toolbar, toolbar is not in the rotorCheck that no shortcuts are missing from the rotor> Not applicable for toolbar, toolbar is not in the rotorTalkback + Chrome on Android> Not applicable for toolbarTalkback + Chrome on Android> Not applicable for toolbarReferences
This test requires a broad knowledge of screen readers; specific references won't be too helpful. This should generally be done with or by someone who is confident in using and interpreting screen readers.
The text was updated successfully, but these errors were encountered: