Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Card component - If focusMode = 'tab-only', and the Card has an onClick event handler, then focusMode regresses to no-tab behaviour #31529

Open
2 tasks done
katiearriagam opened this issue May 31, 2024 · 2 comments

Comments

@katiearriagam
Copy link
Contributor

Library

React Components / v9 (@fluentui/react-components)

System Info

System:
    OS: Windows 10 10.0.22631
    CPU: (12) x64 12th Gen Intel(R) Core(TM) i7-1265U
    Memory: 14.86 GB / 31.83 GB
  Browsers:
    Edge: Chromium (123.0.2420.97)
    Internet Explorer: 11.0.22621.3527

Are you reporting Accessibility issue?

yes

Reproduction

https://stackblitz.com/edit/4g3qid?file=src%2Fexample.tsx

Bug Description

If focusMode = 'tab-only', and the Card has an event handler (especially 'onClick'), then focusMode regresses to no-tab behaviour (which is both undocumented and unexpected).
This behaviour is introduced here.

Actual Behavior

When the card is focusable, onClick event handlers are not allowed and adding them regresses the focusMode to no-tab.

Expected Behavior

When the card is focused, onClick event handlers should be supported. As well as the onKeyDown/onKeyUp for pressing Enter which should match the onClick behavior.

Logs

No response

Requested priority

Normal

Products/sites affected

Microsoft Loop

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@katiearriagam
Copy link
Contributor Author

Related to: #31505

@kolaps33
Copy link
Contributor

I have experience the same behavior... would be nice to fix it...
when it is "tab-only" focus mode, then Enter should bring user focus inside the card...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants