Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBox box-sizing broken the bottom border #4015

Closed
stephenzsy opened this issue Feb 18, 2018 · 2 comments · Fixed by #4102
Closed

ComboBox box-sizing broken the bottom border #4015

stephenzsy opened this issue Feb 18, 2018 · 2 comments · Fixed by #4102
Assignees

Comments

@stephenzsy
Copy link
Contributor

Bug Report

  • Package version(s): 5.46
  • Browser and OS versions: Chrome 64

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? No

Requested priority: Blocking

Products/sites affected: (if applicable)

Describe the issue:

looks this change 5c71bd9 changed the box-sizing from "content-box" to "border-box" which causes the rending broken.

image

Actual behavior:

Expected behavior:

If applicable, please provide a codepen repro:

@stephenzsy
Copy link
Contributor Author

It is visible on the office fabric page now

@lynamemi lynamemi self-assigned this Feb 26, 2018
@lynamemi
Copy link
Collaborator

We changed to border-box to align to TextField and Dropdown and to better support high contrast mode styles. I'll look into where that overlap is coming from.

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants