-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPFx 1.8.0 with @microsoft/sp-office-ui-fabric-core 1.8.0 can't compile #8458
Comments
Usually syntax errors coming from a d.ts file indicate that you're on an incompatible (older) TypeScript build. Is there a way you could upgrade the TS version to something newer? (2.8.1 or above) |
Hello, taking a look at the SPFx 1.8 release notes, notice there is this blurp at https://github.com/SharePoint/sp-dev-docs/wiki/SharePoint-Framework-v1.8-release-notes#support-for-typescript-27-29-and-3x for utilizing a newer version of TypeScript :) |
This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fabric React! |
now i am using: "extends": "./node_modules/@microsoft/rush-stack-compiler-3.3/includes/tsconfig-web.json", and "@microsoft/rush-stack-compiler-3.3": "0.1.17", But it produce me a new errors: [20:10:36] Error - [tsc] src/webparts/album/DocLibPickerDialog.tsx(70,11): error TS2322: Type '{ children: any[]; title: string; subText: string; onDismiss: () => void; showCloseButton: true; }' is not assignable to type 'IntrinsicAttributes & IDialogContentProps'. |
I'm in the same boat. I have tried about a dozen solutions. upgraded tons of packages, changed tons of config, tried everything under the sun and there is NO WAY to get this to work. Does anyone even check this stuff before it goes out the door? This should work out of the gate. |
OK, I was just able to work it out. The problem is with the rush-stack-compiler-3.3 The only version that works is 0.1.6 so if you install the latest version it will fail. You also need to explicitly install typescript. To get it working i did the following: 1 - Delete node_modules and pacakge-lock.json 2 - run the following command: 3 - update tsconfig.json to replace the extends variable with the following: 4 - run the following command: |
Thanks @Paul-Colucci for the followup! |
+ @iclanton as FYI |
Thanks @Paul-Colucci , but i still fail, so sad. |
Hi All
SPFx 1.8.0 with @microsoft/sp-office-ui-fabric-core 1.8.0 can't compileby command : gulp bundle --ship
[23:49:16] Error - [tsc] node_modules/@uifabric/foundation/lib/ISlots.d.ts(68,124): error TS1005: ')' expected.
[23:49:16] Error - [tsc] node_modules/@uifabric/foundation/lib/ISlots.d.ts(68,177): error TS1005: '(' expected.
[23:49:16] Error - [tsc] node_modules/@uifabric/foundation/lib/ISlots.d.ts(68,185): error TS1005: ':' expected.
[23:49:16] Error - [tsc] node_modules/@uifabric/merge-styles/lib/IStyleSet.d.ts(15,67): error TS1005: ';' expected.
[23:49:16] Error - [tsc] node_modules/@uifabric/merge-styles/lib/IStyleSet.d.ts(15,114): error TS1005: '(' expected.
[23:49:16] Error - [tsc] node_modules/@uifabric/merge-styles/lib/IStyleSet.d.ts(15,136): error TS1005: '(' expected.
package.json:
The text was updated successfully, but these errors were encountered: