-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alignment of date axis ticks with data points #30315
Conversation
📊 Bundle size report🤖 This report was generated against df60b15b5a8949962806542be85e72247bb5bff4 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 570e3c0:
|
🕵 fluentuiv8 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 359c271e0defa6122ee30e9af117599c882dfe71 (build) |
packages/react-charting/src/components/HeatMapChart/__snapshots__/HeatMapChart.test.tsx.snap
Show resolved
Hide resolved
Add a link to the guidance in PR description as well. |
this date label remains the same when timezone is UTC. Right? Refers to: packages/react-charting/src/components/HeatMapChart/snapshots/HeatMapChartRTL.test.tsx.snap:178 in 0735a5f. [](commit_id = 0735a5f, deletion_comment = False) |
Previous Behavior
New Behavior
TZ
environment variable is set. Testing scripts (test
andupdate-snapshots
) have been updated to run tests in the UTC timezone by default.test:tz
) has been added to facilitate running tests in different timezones. To accommodate this change, certain date-based snapshot tests have been duplicated for each timezone. This ensures that snapshots are matched correctly within their respective timezones.TZ
environment variable was monitored within dependency packages to confirm that the changes were contained within the react-charting testing process and did not affect external environments.Related Issue(s)