Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of date axis ticks with data points #30315

Merged
merged 12 commits into from
Feb 8, 2024

Conversation

krkshitij
Copy link
Contributor

@krkshitij krkshitij commented Jan 16, 2024

Previous Behavior

Before

New Behavior

After

  • Date-based tests are now configured to execute only when the TZ environment variable is set. Testing scripts (test and update-snapshots) have been updated to run tests in the UTC timezone by default.
  • A new script (test:tz) has been added to facilitate running tests in different timezones. To accommodate this change, certain date-based snapshot tests have been duplicated for each timezone. This ensures that snapshots are matched correctly within their respective timezones.
  • To ensure consistency and prevent unintended side effects, following checks were conducted:
    1. Tests were executed on machines located in various timezones and on the same machine after altering the system timezone settings.
    2. The TZ environment variable was monitored within dependency packages to confirm that the changes were contained within the react-charting testing process and did not affect external environments.
  • A guide has been added with instructions on how to create date objects to be passed as data points in a chart: Creating Date Objects For Chart Data | FluentUI Charting Contrib Docsite

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 16, 2024

📊 Bundle size report

🤖 This report was generated against df60b15b5a8949962806542be85e72247bb5bff4

Copy link

codesandbox-ci bot commented Jan 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 570e3c0:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 16, 2024

🕵 fluentuiv8 No visual regressions between this PR and main

Copy link

size-auditor bot commented Jan 16, 2024

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 359c271e0defa6122ee30e9af117599c882dfe71 (build)

@krkshitij krkshitij marked this pull request as ready for review January 29, 2024 21:37
@krkshitij krkshitij requested a review from a team as a code owner January 29, 2024 21:37
@AtishayMsft
Copy link
Contributor

Add a link to the guidance in PR description as well.

@AtishayMsft
Copy link
Contributor

      aria-label="Mar/01, p1. Execllent (0-200), 50/2391. a good day to start with in Texas with best air quality."

this date label remains the same when timezone is UTC. Right?


Refers to: packages/react-charting/src/components/HeatMapChart/snapshots/HeatMapChartRTL.test.tsx.snap:178 in 0735a5f. [](commit_id = 0735a5f, deletion_comment = False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support UTC timeformat for date axis
3 participants