-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanity check creation of summarizer client around disconnected states. #107
Comments
Related to #198. This issue will be for adding additional telemetry and analysis. We should consider calculating the number of simultaneous summarizers on a document based on documentId, clientId, and timestamps of Summarizer events, because it might be more objective and still useful. I have added clientId to summarizer events in PR #208. |
Answering original questions with more information:
My idea for resolving 2.b is to clean up the SummaryManager logic for detecting if it is already summarizing, and add code to try to recompute the summarizer if the summarizer run promise is fulfilled (indicating summarizer container disconnected).
|
Also PR #362 is related. |
Any chance you can see if we deal with reconnections properly in summarize?
Note - createSummarizer() has "fluid-reconnect": false, which seems correct, assuming the rest works
Any chance that we can add telemetry (erorr) when there is no summurizer in a document and given client is connected?
Thanks!
The text was updated successfully, but these errors were encountered: