Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install shows docker registry password #159

Closed
fpintos opened this issue Sep 26, 2019 · 3 comments
Closed

npm install shows docker registry password #159

fpintos opened this issue Sep 26, 2019 · 3 comments
Labels
area: build Build related issues area: dev experience Improving the experience of devs building on top of fluid
Milestone

Comments

@fpintos
Copy link
Member

fpintos commented Sep 26, 2019

On a Windows 10 machine, I've cloned the repo and ran npm install without having Docker Desktop running.

I was greeted by error messages like these, which included a password:

> root@ postinstall:r11s D:\FluidFramework
> cd server/routerlicious && npm run registryAuth


> root@ registryAuth D:\FluidFramework\server\routerlicious
> docker login -u prague -p A_PASSWORD_WAS_HERE prague.azurecr.io

WARNING! Using --password via the CLI is insecure. Use --password-stdin.
error during connect: Post http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.40/auth: open //./pipe/docker_engine: The system cannot find the file specified. In the default daemon configuration on Windows, the docker client must be run elevated to connect. This error may also indicate that the docker daemon is not running.
npm ERR! code ELIFECYCLE
npm ERR! errno 1                                                                                                        
npm ERR! root@ registryAuth: `docker login -u prague -p A_PASSWORD_WAS_HERE prague.azurecr.io`             
npm ERR! Exit status 1                                                                                                  

After starting Docker, install succeeds.
It still shows the password in the log - do we care about it?

@tylerbutler
Copy link
Member

The password being shown isn’t an issue at the moment, but should be addressed eventually. We can use this issue to track that. The other issue is tracked by #41.

@tylerbutler tylerbutler changed the title Windows: npm install fails if docker desktop is not running and shows password Windows: npm install shows docker registry password Sep 29, 2019
@tylerbutler tylerbutler changed the title Windows: npm install shows docker registry password npm install shows docker registry password Sep 29, 2019
@kurtb
Copy link
Contributor

kurtb commented Oct 3, 2019

It's an intentionally insecure thing we've done to simplify the setup process and keep as few commands as possible to get up and running.

We will need to remove prior to open sourcing. At which point the containers should be available on the public Docker Hub.

@curtisman curtisman modified the milestones: Build2020, Build 2020, OSS Jan 31, 2020
@curtisman curtisman added the area: build Build related issues label Feb 3, 2020
@markfields markfields self-assigned this Apr 23, 2020
@danielroney danielroney added the area: dev experience Improving the experience of devs building on top of fluid label May 7, 2020
@curtisman curtisman assigned kurtb and unassigned markfields May 17, 2020
@curtisman
Copy link
Member

This is removed in PR #2148 already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues area: dev experience Improving the experience of devs building on top of fluid
Projects
None yet
Development

No branches or pull requests

6 participants