Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify when/how Docker is needed in docs #310

Closed
MarcinJuraszek opened this issue Aug 20, 2019 · 4 comments
Closed

Clarify when/how Docker is needed in docs #310

MarcinJuraszek opened this issue Aug 20, 2019 · 4 comments
Assignees
@curtisman @markfields
Labels
area: build Build related issues area: contributor experience documentation Improvements or additions to documentation
Milestone
June 2020

Comments

@MarcinJuraszek
Copy link
Member

Why is Docker a requirement for building the repo? It seems very unnecessary, and makes it harder for people to contribute.
@curtisman
Copy link
Member

curtisman commented Aug 20, 2019 •
edited

Docker is not strictly necessary for building packages/libraries. For client side code, that is probably enough to target our internal routerlicious deployment. But in order to test server code locally or for those that doesn't have access to routerlicious deployment, docker how one can run the test server locally.

@curtisman
Copy link
Member

Probably worth putting that in README.md somewhere.

@tylerbutler tylerbutler transferred this issue from another repository Oct 10, 2019
@tylerbutler tylerbutler added dev-experience documentation Improvements or additions to documentation labels Oct 10, 2019
@curtisman curtisman added the area: build Build related issues label Jan 31, 2020
@curtisman curtisman added this to the Build 2020 milestone Feb 2, 2020
@curtisman curtisman modified the milestones: Build 2020, Public Alpha May 8, 2020
@markfields
Copy link
Member

@curtisman can you take this or delegate to someone else? (I can't assign it right now so just pinging you instead)

@danielroney danielroney modified the milestones: Public Alpha, June 2020 Jun 5, 2020
@markfields markfields changed the title Docker dependency in the build process Clarify when/how Docker is needed in docs Jun 5, 2020
@curtisman
Copy link
Member

https://github.com/microsoft/FluidFramework/wiki/Client and https://github.com/microsoft/FluidFramework/wiki/Server spells it out now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@curtisman curtisman

@markfields markfields

Labels
area: build Build related issues area: contributor experience documentation Improvements or additions to documentation
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
5 participants
@tylerbutler @MarcinJuraszek @curtisman @markfields @danielroney