Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make options strongly typed with interface augmentation #44

Closed
anthony-murphy opened this issue Aug 15, 2019 · 0 comments
Closed

Make options strongly typed with interface augmentation #44

anthony-murphy opened this issue Aug 15, 2019 · 0 comments
Assignees
@anthony-murphy
Labels
api area: loader Loader related issues

Comments

@anthony-murphy
Copy link
Contributor

node_modules@prague\container-loader\src\loader.ts takes options any, we should add an interface here ILoaderOptions, and then use interface augmentation in sub-classes to add optional properties to the options, so we get strong typing for options.
@anthony-murphy anthony-murphy transferred this issue from another repository Sep 17, 2019
@curtisman curtisman added api area: loader Loader related issues labels Feb 2, 2020
@curtisman curtisman added this to the Build 2020 milestone Feb 2, 2020
@curtisman curtisman modified the milestones: Build 2020, February 2020 Feb 10, 2020
@curtisman curtisman modified the milestones: February 2020 , March 2020 Feb 24, 2020
@anthony-murphy anthony-murphy modified the milestones: March 2020, Future Mar 26, 2020
@danielroney danielroney removed this from the Future milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthony-murphy anthony-murphy

Labels
api area: loader Loader related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tylerbutler @anthony-murphy @curtisman @danielroney