Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate logic: requestWithRefresh #98

Closed
vladsud opened this issue Sep 20, 2019 · 3 comments
Closed

Duplicate logic: requestWithRefresh #98

vladsud opened this issue Sep 20, 2019 · 3 comments
Assignees
@jatgarg

Comments

@vladsud
Copy link
Contributor

vladsud commented Sep 20, 2019

Can we remove requestWithRefresh()?
And replace it with getWithRetryForTokenRefresh if functionality is needed?
Thanks!
@jatgarg
Copy link
Contributor

jatgarg commented Nov 1, 2019 •
edited

requestWithRefresh is in odspUtils package and getWithRetryForTokenRefresh is in driver. Do we want driver to take the dependency on odspUtils package. Odsp utils should not take the dependency on driver. The other option is to move getWithRetryForTokenRefresh to odsp-utils pacakge.
Also requestWithRefresh name could be change because it is very specific for a token refresh and otherwise too.
@vladsud

@vladsud
Copy link
Contributor Author

vladsud commented Nov 1, 2019

Moving to odsp-utils sounds reasonable to me

@jatgarg
Copy link
Contributor

jatgarg commented Nov 5, 2019

#533

@jatgarg jatgarg closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jatgarg jatgarg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vladsud @jatgarg