Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Was the unused code left by design, or was it perhaps an oversight? #92

Closed
InCerryGit opened this issue Mar 22, 2024 · 0 comments · Fixed by #94
Closed

Was the unused code left by design, or was it perhaps an oversight? #92

InCerryGit opened this issue Mar 22, 2024 · 0 comments · Fixed by #94
Assignees
@TedHartMS
Labels
question Further information is requested

Comments

@InCerryGit
Copy link
Contributor

I've noticed that there are some codes or variables that haven't been used. Is this by design, or might it have been an oversight?

The objectLogDevice ：

garnet/libs/storage/Tsavorite/cs/src/core/Allocator/SpanByteAllocator.cs

Line 414 in 9ca34a2

IDevice usedObjlogDevice = objectLogDevice;

The newCurrentAddress ：

garnet/libs/storage/Tsavorite/cs/src/core/TsavoriteLog/TsavoriteLogIterator.cs

Line 497 in 9ca34a2

while (ExpandGetNextInternal(startPhysicalAddress, ref totalLength, out long newCurrentAddress, out endLogicalAddress, out isCommitRecord))

@InCerryGit InCerryGit mentioned this issue Mar 22, 2024
Merged
@darrenge darrenge added the question Further information is requested label Mar 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TedHartMS TedHartMS

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused code InCerryGit/garnet
3 participants
@darrenge @TedHartMS @InCerryGit