Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss binder integration #13

Closed
choldgraf opened this issue May 23, 2019 · 7 comments
Closed

Discuss binder integration #13

choldgraf opened this issue May 23, 2019 · 7 comments
Labels
documentation Improving user and internal documentation enhancement New feature or request

Comments

@choldgraf
Copy link
Contributor

Moving the Binder conversation here so that we're not just chatting in a closed PR :-)

re: repository size, it's OK to include extra cruft up to a certain point. If it's "can I include a bunch of notebooks that might be big-ish" that's totally fine. If it's "I want to include a 500MB dataset in my repository" that might be more of a performance hit. The biggest time-sink in Binder is the time it takes to "Docker pull" onto a node when somebody launches a repository for the first time on that node. After that, Binder uses the docker cache within the same node and it is much faster.

re: this repository or another repository, it can be whatever you'd like! Many people just use whichever repository they use for their documentation.

@choldgraf choldgraf added the enhancement New feature or request label May 23, 2019
@andrewhead andrewhead added the documentation Improving user and internal documentation label May 23, 2019
@andrewhead
Copy link
Collaborator

Good call on the move to an issue :-)

re: repository size, thanks for the clarification! Yeah, this is a pretty small repository (<10M of text and images) on mybinder.org, so I'll just publish this repo.

re: the right repository, great. With that rule of thumb, I'll keep the binder files in this repository for now and keep everything in one place.

@choldgraf
Copy link
Contributor Author

choldgraf commented May 24, 2019

cool! let me know if you'd like me to give some thoughts or pointers! You know what kinda notebook would best-show off Gather, so I'll leave that part to you :-)

@andrewhead
Copy link
Collaborator

sweet! already got a notebook and everything put together ^_^

I'm working on deploying to Binder with a workspace so the notebook opens right up. I found ian-r-rose's helpful repo, though got hung up as Lab has a 404 for the workspace.json request.

Have you deployed Lab with a workspace configuration file before? If so, could I trouble you to take a quick look at the say 7 lines of code I've got to try it out to if anything obvious missing (like, do I need to use the Jupyter 1.0 alpha like ian-r-rose was)?

About to put this on pause for a few weeks of travel. Thanks again for the timely tipz, I'm pumped to have this repo contain a live online demo!

@choldgraf
Copy link
Contributor Author

It seems like the binder does work, just not yet with the workspace pre-configured. E.g. this link will open jupyterlab w/ the notebook you've provided:

https://mybinder.org/v2/gh/microsoft/gather/add-binder-notebook?urlpath=lab/tree/binder%2FTry%20out%20nbgather.ipynb

Is there anything really specific in the workspace that isn't possible w/ this workflow?

@andrewhead
Copy link
Collaborator

Sure that works! Great catch!

@andrewhead
Copy link
Collaborator

Merged a link to the Binder demo into the README in 253eab6. The demo's live!

@choldgraf
Copy link
Contributor Author

wahoo! welcome back from your trip :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improving user and internal documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants