Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to support Jupyter Lab API 1.0 #22

Closed
andrewhead opened this issue Jul 15, 2019 · 1 comment
Closed

Bump to support Jupyter Lab API 1.0 #22

andrewhead opened this issue Jul 15, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@andrewhead
Copy link
Collaborator

When setting up a development environment for nbgather, linking the extension fails because the Jupyter Lab package versions in package.json are not compatible with the version of Jupyter Lab that is now downloaded by pip by default.

The project should be refactored to use APIs from the Jupyter Lab project version >=1.0.
@andrewhead andrewhead added the enhancement New feature or request label Jul 15, 2019
@andrewhead andrewhead mentioned this issue Jul 22, 2019
Merged
2 tasks
@andrewhead
Copy link
Collaborator Author

The version is bumped! nbgather can once again be installed with the latest version of Jupyter Lab via the normal command jupyter labextension install nbgather.

If someone tries to install nbgather into an earlier version of Jupyter Lab (say 0.35.4), due to the default behavior of jupyter labextension install, it will install an earlier version of this plugin that was compatible with that version of Jupyter Lab (say, nbgather v0.4.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewhead