Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for gathering not appearing in version browser #34

Closed
andrewhead opened this issue Aug 22, 2019 · 3 comments
Closed

Icons for gathering not appearing in version browser #34

andrewhead opened this issue Aug 22, 2019 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@andrewhead
Copy link
Collaborator

Describe the bug

The icons for "Open in notebook" and "Copy to clipboard" in the version browser are not appearing.

image

To Reproduce

Click on a variable or output, then click on "Gather to... Version Browser". You should be able to see that the icons are missing on the gather buttons.

Expected behavior

The icons should appear on the buttons, like so (screenshot taken from the version of gather currently hosted on BinderHub):

image

Additional context

This problem was probably introduced when gather started using Jupyter Lab libraries version >1.0 and the paths to the Jupyter icons changed. I already fixed the paths for the icons for the buttons in the Jupyter notebook toolbar in this commit, so we probably just need to point the CSS classes of the buttons in the version browser interface to the classes defined in that commit.

@andrewhead andrewhead added bug Something isn't working good first issue Good for newcomers labels Aug 22, 2019
@rdrahul
Copy link
Contributor

rdrahul commented Sep 8, 2019

Can i take this up?

@andrewhead
Copy link
Collaborator Author

Hi @rdrahul thanks for pinging ^_^ Yeah, please do! I'm happy to review a PR if you want to put something together.

@andrewhead
Copy link
Collaborator Author

Solved by @rdrahul in #36 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants