Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTimeStamp API that takes double as an arg should handle NaN #49

Closed
dsgrieve opened this issue Aug 18, 2021 · 2 comments
Closed

DateTimeStamp API that takes double as an arg should handle NaN #49

dsgrieve opened this issue Aug 18, 2021 · 2 comments
Assignees
@anantk24
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dsgrieve
Copy link
Member

Double.NaN should be treated as 0.0.

I would expect, for example, that new DateTimeStamp(0.0).add(Double.NaN).equals(new DateTimeStamp(0.0)) to be true.
@dsgrieve dsgrieve added bug Something isn't working good first issue Good for newcomers labels Aug 18, 2021
@anantk24
Copy link
Contributor

I will take this up . Assign it to me.

@anantk24 anantk24 mentioned this issue Aug 18, 2021
Merged
@anantk24
Copy link
Contributor

Added pull request #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anantk24 anantk24

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karianna @dsgrieve @anantk24