Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

orgList is not remapped to lowercase when changing via PATCH route #178

Open
k----n opened this issue Mar 22, 2020 · 0 comments · May be fixed by #179
Open

orgList is not remapped to lowercase when changing via PATCH route #178

k----n opened this issue Mar 22, 2020 · 0 comments · May be fixed by #179

Comments

@k----n
Copy link

k----n commented Mar 22, 2020 •
edited

The problem lies here:

ghcrawler/lib/crawler.js

Lines 30 to 37 in 0ac1107

_reconfigure(current, changes) {
// ensure the orgList is always lowercase
const orgList = changes.find(patch => patch.path === '/orgList');
if (orgList) {
debug('orgList changed');
this.options.orgList = orgList.value.map(element => element.toLowerCase());
}
}

The path is not only /orgList

ghcrawler/lib/crawler.js

Line 32 in 0ac1107

const orgList = changes.find(patch => patch.path === '/orgList');

When reassigning this.options.orgList, this.options.orgList.map(element => element.toLowerCase()) should be used and not orgList.value.map(element => element.toLowerCase()).

ghcrawler/lib/crawler.js

Line 35 in 0ac1107

this.options.orgList = orgList.value.map(element => element.toLowerCase());

@k----n k----n linked a pull request Mar 22, 2020 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix case not changing when patching orgList k----n/ghcrawler
1 participant
@k----n