Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git status should not fail when it is unable to open cache file #126

Closed
jamill opened this issue Mar 1, 2019 · 0 comments · Fixed by #270
Closed

git status should not fail when it is unable to open cache file #126

jamill opened this issue Mar 1, 2019 · 0 comments · Fixed by #270
Assignees

Comments

@jamill
Copy link
Member

jamill commented Mar 1, 2019

In microsoft/VFSForGit#663, a functional test failed to run status because git encountered an error (access denied) when reading from a status cache file.

Reading status from a cache file is a best effort operation. If the file does not exist, we fall back to computing a fresh status. The intention is that failing to read from the cache file is also a best effort, and we should not terminate if we are unable to read an existing file.

We should be more resilient to these types of errors, and fallback to computing full status gracefully rather than terminating. The issue here is the utility xopen function used by status cache deserialization logic will terminate if it encounters an issue reading the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants