Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Procedure to upgrade for the support many Vertex Colors ? #111

Open
jimver04 opened this issue Nov 24, 2022 · 2 comments
Open

Procedure to upgrade for the support many Vertex Colors ? #111

jimver04 opened this issue Nov 24, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed triaged Issues that have been triaged

Comments

@jimver04
Copy link

Hi,

from what I see there is only one Vertex Color level named as constexpr const char* ACCESSOR_COLOR_0 = "COLOR_0";.
if I add

constexpr const char* ACCESSOR_COLOR_1 = "COLOR_1";
constexpr const char* ACCESSOR_COLOR_2 = "COLOR_2";

would be sufficient ?

image

Best,
Dimitrios
@jimver04 jimver04 changed the title Procedure to upgrade for the the support many Vertex Colors ? Procedure to upgrade for the support many Vertex Colors ? Nov 25, 2022
@jimver04 jimver04 mentioned this issue Nov 25, 2022
Closed
@jimver04
Copy link
Author

It wasn't difficult. I have done some changes:

See my pull request: #112

@bghgary bghgary added enhancement New feature or request help wanted Extra attention is needed triaged Issues that have been triaged labels Dec 7, 2023
@bghgary
Copy link
Contributor

bghgary commented Dec 7, 2023

The PR was never merged. If you still want this, please reopen the PR and fix the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed triaged Issues that have been triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code changes for closing 110 and 111 jimver04/glTF-SDK
2 participants
@jimver04 @bghgary