New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessor::Sparse needs various improvements #19

Open

agrittmsft opened this issue Nov 9, 2018 · 0 comments

Labels

bug help wanted triaged

Contributor

agrittmsft commented Nov 9, 2018 •

edited

Accessor.sparse member should be a unique_ptr instead of just Sparse so that a null value can be represented properly
Accessor::Sparse should inherit from glTFProperty
Accessor::Sparse.indices and Accessor::Sparse.values should inherit from glTFProperty

Currently any extensions or extras stored on these nodes will be lost upon import.

agrittmsft added the bug label

bghgary added help wanted triaged labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment