Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend sqlexp.MsgNotice to capture SQL notice fields like state #18

Closed
shueybubbles opened this issue May 16, 2022 · 0 comments
Closed
Labels
enhancement New feature or request
Projects

Comments

@shueybubbles
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The driver discards state/class/number fields from tokenInfo.
sqlcmd needs access to those fields, per microsoft/go-sqlcmd#76
The driver should extend sqlexp.MsgNotice in a way that preserves the existing contract while provided the remaining fields to apps that know about them.

Describe the solution you'd like
Either:
Implement a new type that extends sqlexp.MsgNotice, and either:

  1. Post both the mssql-specific message type and the MsgNotice struct and rely on the client to only use one of the two, or
  2. Extend MsgNotice in a way that existing switch statements on the type will work for clients that don't know about the new type.
@shueybubbles shueybubbles added the enhancement New feature or request label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
V1
Awaiting triage
Development

No branches or pull requests

1 participant