Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic mirroring from upstream (untouched upstream branches) #4

Closed
dagood opened this issue Mar 12, 2021 · 2 comments
Closed

Automatic mirroring from upstream (untouched upstream branches) #4

dagood opened this issue Mar 12, 2021 · 2 comments

Comments

@dagood
Copy link
Member

dagood commented Mar 12, 2021

We plan to mirror branches from https://go.googlesource.com/go to this repo with their original names. Forked branches will begin with microsoft/ to avoid collisions.

This issue tracks creating automation to push branch updates to this repo from upstream.

@dagood
Copy link
Member Author

dagood commented Mar 18, 2021

I've been considering why we want to do this. The reasons I can think of:

  • Convenience when making a fresh clone: you get some info about the upstream state (as of the last mirror).
    • Since we plan to have an infra branch that doesn't modify any of the Go source code, this doesn't seem like a huge value.
    • If you need a completely blank slate for upstreaming some changes, why not just
      git remote add golang https://go.googlesource.com/go?
  • Detecting non-FF pushes that happen upstream.

Setting it up securely could be an issue. I'm not sure if Fabric Bot is able to do mirror pushes without PRs based on https://docs.opensource.microsoft.com/tools/fabricbot/index.html (https://github.com/microsoftfabricbot). Making a new bot account could do it, but IIRC giving more bots write permission is discouraged. (Maybe more/less in microsoft than dotnet?)


@microsoft/golang-compiler Does this reasoning seem good? Are there benefits to maintaining mirrored branches that I'm missing (or undervalued)?

I think we can deprioritize mirroring from upstream and consider/decide later. The auto-merges are the critical part. We could depend on auto-mirroring as the source of our merges, but I don't see a reason to.

@dagood dagood changed the title Automatic mirroring from upstream Automatic mirroring from upstream (untouched upstream branches) Jun 7, 2021
@dagood
Copy link
Member Author

dagood commented Feb 3, 2022

With the switch to submodules, we now have a mirror for internal use (https://dev.azure.com/dnceng/internal/_git/microsoft-go-mirror), but no public mirroring is needed.

@dagood dagood closed this as completed Feb 3, 2022
@dagood dagood removed this from On Deck in Infrastructure Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant