Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finally doesn't work properly without rvo optimisations #94

Closed
AntonBikineev opened this issue Sep 29, 2015 · 3 comments
Closed

finally doesn't work properly without rvo optimisations #94

AntonBikineev opened this issue Sep 29, 2015 · 3 comments
Labels
resolved

Comments

@AntonBikineev
Copy link

finally function heavily relies on rvo optimisation. If you compile with -fno-elide-constructor, you'll get util_tests errors
@AntonBikineev AntonBikineev changed the title finally doesn't work properly with rvo optimisations finally doesn't work properly without rvo optimisations Sep 29, 2015
@neilmacintosh
Copy link
Collaborator

This was resolved recently by PR #90.

@jbcoe
Copy link

jbcoe commented Sep 29, 2015

I can't reproduce this issue.

I believe it was fixed by ae24c0f and earlier commits.

@AntonBikineev
Copy link
Author

@neilmacintosh @jbcoe Yes, it seems we did the same job at almost the same time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbcoe @AntonBikineev @neilmacintosh