Remove the last empty assistant message for ChatGPT API call #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red for OpenAI API call
Allow for partial content in case open ai eventually supports that, also clean up the whitespace handling.
|
Thanks! I tweaked things to be a bit more future compatible, and handle whitespace more cleanly. Will merge soon :) |
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage ? 70.15%
=======================================
Files ? 49
Lines ? 2858
Branches ? 0
=======================================
Hits ? 2005
Misses ? 853
Partials ? 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way the regex was written, currently there is always an empty message produced at the end of messages list, eg:
[{'role': 'system', 'content': 'You are a helpful assistant.'}, {'role': 'user', 'content': 'Whats is the meaning of life??'}, {'role': 'assistant', 'content': ''}].This PR fix the regex and thus remove this empty message.