Complete program execution on exceptions in async_mode=True #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request with implementation as suggested in guidance-ai#206.
jprafael
commented
Jun 14, 2023
| task.cancel() | ||
| loop.run_until_complete(asyncio.sleep(0)) # give the loop a chance to cancel the tasks | ||
|
|
||
| # TODO: do we really want to close the loop? what if it is used by others? |
There was a problem hiding this comment.
@slundberg is it possible that the loop is shared with other usages and that this loop.close() should not be called (and be the caller's resposability to do that?)
yufei-realm
approved these changes
Jun 14, 2023
|
@microsoft-github-policy-service agree company="Realm" |
|
Thanks! Will dig into this soon. |
Codecov Report
@@ Coverage Diff @@
## main #231 +/- ##
==========================================
- Coverage 67.74% 67.63% -0.11%
==========================================
Files 54 54
Lines 2970 2985 +15
==========================================
+ Hits 2012 2019 +7
- Misses 958 966 +8
|
|
Thank you again for this PR @jprafael ! It looks good to me, and I am merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and adds unit test for #206. Uses the proposed implementation with extra stuff to clean-up tasks after completion.