Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.11: dependency on containerd/cgroups was accidentally rolled back from v3 to v1? #1889

Closed
AkihiroSuda opened this issue Sep 7, 2023 · 2 comments
Closed

v0.11: dependency on containerd/cgroups was accidentally rolled back from v3 to v1? #1889

AkihiroSuda opened this issue Sep 7, 2023 · 2 comments

Comments

@AkihiroSuda
Copy link

AkihiroSuda commented Sep 7, 2023 •
edited
Loading

https://github.com/microsoft/hcsshim/blob/v0.10.0/go.mod#L11

github.com/containerd/cgroups/v3 v3.0.2

https://github.com/microsoft/hcsshim/blob/v0.11.0/go.mod#L10

github.com/containerd/console v1.0.3

Was this rolled back by an accident?

I also wonder why this change doesn't show up in v0.10.0...v0.11.0
@AkihiroSuda AkihiroSuda mentioned this issue Sep 7, 2023
Closed
@mtrmac
Copy link

mtrmac commented Sep 11, 2023

I see v0.11.0 (750e11b) as one commit ahead of v0.10.0-rc.8 (8fa2489 from 2023-05-04 23:57:01), about 60 commits behind v0.10.0.

And there is some explanation in the release notes of https://github.com/microsoft/hcsshim/releases/tag/v0.10.0 / https://github.com/microsoft/hcsshim/releases/tag/v0.11.0 , so it seems to be intentional.

@mtrmac mtrmac mentioned this issue Sep 11, 2023
Merged
1 task
@AkihiroSuda
Copy link
Author

Thank you for the answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtrmac @AkihiroSuda