Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect LIB paths in NuGet package #12

Closed
JunielKatarn opened this issue Jun 10, 2020 · 1 comment
Closed

Incorrect LIB paths in NuGet package #12

JunielKatarn opened this issue Jun 10, 2020 · 1 comment

Comments

@JunielKatarn
Copy link

See __vcpkg.targets:

      <AdditionalLibraryDirectories Condition="'$(__VcpkgNormalizedConfiguration)' == 'Release'">%(AdditionalLibraryDirectories);$(__VcpkgRoot)lib;$(__VcpkgRoot)lib\manual-link</AdditionalLibraryDirectories>
      <AdditionalLibraryDirectories Condition="'$(__VcpkgNormalizedConfiguration)' == 'Debug'">%(AdditionalLibraryDirectories);$(__VcpkgRoot)debug\lib;$(__VcpkgRoot)debug\lib\manual-link</AdditionalLibraryDirectories>

Library paths are suffixed with non-existing directory manual-link.
This prevents LIB dependencies from being resolved by consuming projects.

Suggested solution: Remove the \manual-link suffix from the .targets file.
Additional suggestion: Move MSBuild properties and item definitions into a .props file instead.

@tudorms
Copy link
Member

tudorms commented Oct 30, 2020

Out of date, fixed a while ago with NuGet structure updates.

@tudorms tudorms closed this as completed Oct 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants