Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage for submit_to_azure_if_needed #33

Closed
dumbledad opened this issue Jul 28, 2021 · 2 comments
Closed

Improve coverage for submit_to_azure_if_needed #33

dumbledad opened this issue Jul 28, 2021 · 2 comments
Assignees
@dumbledad
Projects
v 0.1

Comments

@dumbledad
Copy link
Contributor

  • Break submit_to_azure_if_needed into smaller functions
  • Write unit tests for those smaller functions
  • Write unit tests for the various utility functions they rely on (copied from Inner Eye where possible)
  • Where appropriate (hopefully everywhere!) mark as @pytest.mark.fast
@dumbledad dumbledad self-assigned this Jul 28, 2021
@dumbledad
Copy link
Contributor Author

Related to Issue #13, so I'll need to be careful not to tread on @JonathanTripp's toes

@dumbledad dumbledad mentioned this issue Jul 28, 2021
Merged
@ant0nsc ant0nsc added this to Done in v 0.1 Aug 3, 2021
@dumbledad
Copy link
Contributor Author

Also covered in PR #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dumbledad dumbledad

Labels
None yet
Projects
No open projects
v 0.1
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dumbledad