Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CountVectorizer implementation #203

Open
ksaur opened this issue Jul 20, 2020 · 6 comments
Open

CountVectorizer implementation #203

ksaur opened this issue Jul 20, 2020 · 6 comments

Comments

@ksaur
Copy link
Collaborator

ksaur commented Jul 20, 2020

The existing CountVectorizer code has jit things such as in the forward function

doc_ids = torch.jit.annotate(List[Tensor], [])  # noqa: F821

which we need to do a bit of a work around so that it doesn't fail at

  File "/root/hummingbird/hummingbird/ml/_container.py", line 63, in forward
    raise RuntimeError("Inputer tensor {} of not supported type {}".format(input_name, type(inputs[i])))

because it's not a tensor

See this branch

@Hemantr05
Copy link

@ksaur I'm solving the same in issue #293 as discussed in issue #164

@ksaur
Copy link
Collaborator Author

ksaur commented Sep 14, 2020

Hi @Hemantr05,

For issue #164, there are two parts:

We really appreciate your enthusiasm!! If you finish your current two issues (#293 and #273) you can get started on this third one! :) Let me know if you have questions or would like to change which issue you focus on! Thanks again!

@interesaaat
Copy link
Collaborator

Actually you can take a look at count vectorizer code at this old branch.

@ksaur
Copy link
Collaborator Author

ksaur commented Sep 14, 2020

@interesaaat - I see that I also had the old CV code already posted in the original post above (See "this branch"). :-D I can delete mine if you made changes in yours? (else the appear to be dups)

@interesaaat
Copy link
Collaborator

I made no changes, let me delete mine then since it is not used.

@Hemantr05
Copy link

@ksaur Sure. Will finish the previously assigned issue first and get back to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants