Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert visual should have a clear distinction between present & not present #305

Closed
ccrowley96 opened this issue Mar 31, 2022 · 1 comment · Fixed by #297
Closed

Alert visual should have a clear distinction between present & not present #305

ccrowley96 opened this issue Mar 31, 2022 · 1 comment · Fixed by #297
Labels
bug 🐛 Something isn't working

Comments

@ccrowley96
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

Request from @rinisbet

As soon as trigger expression for Alerts is != "", the blue badge preview (sans icon, see Alert config feedback in the other chat) should appear on the preview popover... no alert text showing of course until they start typing that

Reasoning: it's a true live view of the badge when the alert is "valid"

To Reproduce
Steps to reproduce the behavior:

  1. Go to Alerts tab (in new behavior creation)
  2. Enter text in trigger expression box
  3. No preview shows of alert configured (color & icon are still null)

Expected behavior
Alerts need default badge / color values. Bottom part of form should probably disappear when no trigger expression is active, indicating alert is not present

Screenshots
Enter text in trigger expression (alert doesn't show)

image

Select a badge icon (alert shows only badge, no color)

image

Click on color icon picker (alert shows badge & color)
image

@ccrowley96 ccrowley96 added the bug 🐛 Something isn't working label Mar 31, 2022
@ccrowley96
Copy link
Contributor Author

@rinisbet @msnyder-msft -- logged your alert feedback here Riley to avoid it being lost in chat history

@ccrowley96 ccrowley96 linked a pull request Mar 31, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant